Skip to content

fix: handle resubmission replay for canisters without ExpiredTransaction #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpahlavi wants to merge 2 commits into from
Closed

fix: handle resubmission replay for canisters without ExpiredTransaction #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a99910a
fix: handle resubmission replay for canisters without ExpiredTransaction
lpahlavi Apr 10, 2026
4b85971
Merge branch 'main' into lpahlavi/migrate-resubmission-queue
lpahlavi Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions minter/src/state/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,14 @@ impl State {
new_signature: &Signature,
new_slot: Slot,
) {
// Handle event logs from before ExpiredTransaction was introduced:
// if the old transaction is still in submitted_transactions (no preceding
// ExpiredTransaction event in the log), move it to transactions_to_resubmit first.
if !self.transactions_to_resubmit.contains_key(old_signature)
&& self.submitted_transactions.contains_key(old_signature)
{
self.process_transaction_expired(old_signature);
}
Comment thread
lpahlavi marked this conversation as resolved.
Comment thread
lpahlavi marked this conversation as resolved.
let old_transaction = self
.transactions_to_resubmit
.remove(old_signature)
Expand Down
Loading