feat: DEFI-1902: Add support for ICRC-10#178
Open
mbjorkqvist wants to merge 2 commits intomainfrom
Open
Conversation
marc0olo
approved these changes
May 8, 2026
Member
marc0olo
left a comment
marc0olo
left a comment
There was a problem hiding this comment.
ICRC-10 implementation looks correct: proper return type, self-listing of ICRC-10 in the standards list, both endpoints returning the same data via the shared helper, DID updated. Two minor pre-existing URL issues flagged inline.
| }, | ||
| endpoints::SupportedStandard { | ||
| name: "ICRC-103".to_string(), | ||
| url: "https://github.com/dfinity/ICRC/tree/main/ICRCs/ICRC-103".to_string(), |
Member
There was a problem hiding this comment.
Pre-existing, but since you are touching this list: a tree/ URL resolves to a directory listing, not a document. The file exists at blob/main: https://github.com/dfinity/ICRC/blob/main/ICRCs/ICRC-103/ICRC-103.md
Member
|
Pre-existing as well, but worth a follow-up: the ICRC-106 URL points to a closed (unmerged) GitHub PR. The spec file has since landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the ICRC-10 standard, which basically consists of adding an
icrc10_supported_standardsquery endpoint.