fix(infra): remove _headers (not applicable to IC asset canister hosting)#183
Merged
fix(infra): remove _headers (not applicable to IC asset canister hosting)#183
Conversation
6 tasks
marc0olo
force-pushed
the
infra/agent-docs-spec-compliance
branch
from
b774521 to
a1028e0
Compare
raymondk
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #182.
The
public/_headersfile added in #182 is a Cloudflare Pages convention and has no effect on IC asset canister hosting. The site is deployed viaicp.yamlusing@dfinity/asset-canister, which serves files by URL path and does not process_headersfiles.Custom response headers for
.mdfiles are already configured inpublic/.ic-assets.json5(Content-Type: text/markdown; charset=utf-8for**/*.md).The
content-negotiationspec check (serving different content for the same URL based on theAcceptheader) is not achievable with the IC asset canister without an edge worker or CDN middleware. See #181 for tracking.Sync recommendation
hand-written