feat: add icp-cli support for rust/hello_world#1309
Merged
Conversation
- Add icp.yaml with @dfinity/rust and @dfinity/asset-canister recipes - Migrate frontend from @dfinity/agent to @icp-sdk/core with @icp-sdk/bindgen for auto-generating TypeScript bindings - Add backend/backend.did as committed interface definition for bindgen - Frontend vite.config.js auto-detects icp-cli vs dfx for dev server, both paths set ic_env cookie for unified root key handling - Use Vite loadEnv for safe build-time env var injection (dfx compat) - Update README.md with overview, icp-cli instructions, and Candid regeneration guide - Replace BUILD.md with concise icp-cli version - Add **/frontend/src/bindings/ and Cargo.lock to .gitignore
viviveevee
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icp.yamlconfiguration for icp-cli alongside existingdfx.json@dfinity/agentto@icp-sdk/corewith@icp-sdk/bindgenfor auto-generating TypeScript bindings from the Candid interfacebackend/backend.didas a committed interface definition (used by bindgen at build time)vite.config.jsauto-detects icp-cli vs dfx for the dev server — both paths set theic_envcookie for unified root key and canister ID handlingloadEnvfor safe build-time env var injection (scoped toCANISTER_*prefix)README.mdwith overview, icp-cli instructions, and Candid regeneration guideBUILD.mdwith concise icp-cli version**/frontend/src/bindings/andCargo.lockto.gitignore