refactor: Use @icp-sdk/core for Principal and remove @dfinity deps#199
Closed
raymondk wants to merge 1 commit intodfinity:mainfrom
Closed
refactor: Use @icp-sdk/core for Principal and remove @dfinity deps#199raymondk wants to merge 1 commit intodfinity:mainfrom
@icp-sdk/core for Principal and remove @dfinity deps#199raymondk wants to merge 1 commit intodfinity:mainfrom
Conversation
|
Thank you for contributing! Unfortunately this repository does not accept external contributions yet. We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request. We hope you understand and will come back once we accept external PRs. — The DFINITY Foundation |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the codebase off the deprecated @dfinity/* packages by switching Principal imports to @icp-sdk/core and removing the direct @dfinity dependencies.
Changes:
- Replaced
@dfinity/principalimports with@icp-sdk/core/principalacross runtime and test code. - Removed
@dfinity/utilsusage by inliningisNullishin the CLI. - Updated
package.json/package-lock.jsonto drop@dfinity/principal+@dfinity/utilsand add@icp-sdk/core.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/signer/eth.ts | Switch Principal type import to @icp-sdk/core/principal. |
| src/signer/eth.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/signer/btc.ts | Switch Principal type import to @icp-sdk/core/principal. |
| src/signer/btc.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/schnorr/ed25519.ts | Switch Principal type import to @icp-sdk/core/principal. |
| src/schnorr/ed25519.tests/pocketic_derivation.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/schnorr/ed25519.tests/mainnet_derivation.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/schnorr/bip340secp256k1.tests/pocketic_derivation.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/schnorr/bip340secp256k1.tests/mainnet_derivation.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/ecdsa/secp256k1.ts | Switch Principal type import to @icp-sdk/core/principal. |
| src/ecdsa/secp256k1.tests/pocketic_derivation.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/ecdsa/secp256k1.tests/mainnet_derivation.test.ts | Switch test Principal import to @icp-sdk/core/principal. |
| src/cli.ts | Switch Principal import to @icp-sdk/core/principal and inline isNullish. |
| package.json | Remove direct @dfinity/* deps and add @icp-sdk/core. |
| package-lock.json | Lockfile updated to reflect dependency changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Inlined from `@dfinity/utils` to avoid depending on the package for a single helper. | ||
| const isNullish = <T>( | ||
| argument: T | undefined | null, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dependency on the @dfinity packages since they're being deprecated in favor of icp-sdk/core