Skip to content

avoid pocket-ic crate#101

Merged
mraszyk merged 3 commits intomraszyk/effective-canister-idfrom
mraszyk/effective-canister-id-self-contained
Nov 18, 2024
Merged

avoid pocket-ic crate#101
mraszyk merged 3 commits intomraszyk/effective-canister-idfrom
mraszyk/effective-canister-id-self-contained

Conversation

@mraszyk
Copy link
Copy Markdown
Contributor

@mraszyk mraszyk commented Nov 18, 2024

No description provided.

Copy link
Copy Markdown
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much cleaner to me!

@mraszyk mraszyk marked this pull request as ready for review November 18, 2024 18:19
@mraszyk mraszyk requested a review from a team as a code owner November 18, 2024 18:19
@mraszyk mraszyk merged commit 40d8433 into mraszyk/effective-canister-id Nov 18, 2024
@mraszyk mraszyk deleted the mraszyk/effective-canister-id-self-contained branch November 18, 2024 18:19
mraszyk added a commit that referenced this pull request Nov 18, 2024
* feat: make ic-repl work against PocketIC

* lazy

* dfx stop

* clean

* use fn get_default_effective_canister_id

* simplify deps

* bump dfx

* dfx version

* Revert "dfx version"

This reverts commit ab157dd.

* deps

* dfx

* avoid pocket-ic crate (#101)

* avoid pocket-ic crate

* .

* trim_end_matches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants