feat: Add spinner to network launcher download#535
Merged
adamspofford-dfinity merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
Adds progress spinner feedback for icp-cli-network-launcher downloads/updates, leveraging the existing ProgressManager utilities in icp-cli.
Changes:
- Refactors
ProgressManagerto support creating a spinner progress bar without a canister-name prefix. - Wraps network launcher downloads in
network startwithexecute_with_progressto show spinner + success/failure messaging. - Updates
network updateto show spinner progress while downloading the latest launcher.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/icp-cli/src/progress.rs | Splits progress bar creation into “independent” (no prefix) vs. canister-prefixed progress bars. |
| crates/icp-cli/src/commands/network/update.rs | Adds spinner progress around launcher update flow and switches to progress-bar success/failure messaging. |
| crates/icp-cli/src/commands/network/start.rs | Adds spinner progress around launcher download when cache is stale/missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raymondk
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.