Open
Conversation
raymondk
reviewed
Apr 30, 2026
marc0olo
force-pushed
the
infra/matomo-localhost-guard
branch
from
e493901 to
eb5249a
Compare
marc0olo
added a commit
to dfinity/developer-docs
that referenced
this pull request
May 4, 2026
## Summary
- Use `endsWith("localhost")` instead of `!== "localhost"` in the Matomo
guard so tracking is also skipped on `*.localhost` subdomains (e.g.
`myapp.localhost`), which browsers treat as local
- Aligns with the same fix applied in dfinity/icp-cli#538
## Sync recommendation
hand-written
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
location.hostnameguard so tracking is skipped onlocalhostand127.0.0.1matomo.jsis deployed once at the site root and referenced by all versioned builds, this fix covers all versions globally