feat: token management, deployment with cycles#63
Closed
viviveevee wants to merge 7 commits intomainfrom
Closed
Conversation
viviveevee
changed the title
rikonor
approved these changes
Aug 22, 2025
rikonor
reviewed
Sep 8, 2025
| #[clap(flatten)] | ||
| pub settings: CanisterSettings, | ||
|
|
||
| /// How many cycles the canister should be created with. Also needs to pay for canister creation cost. |
Contributor
There was a problem hiding this comment.
Could we rework this docstring? Perhaps:
Amount of canister cycles to provide the created canister
What is meant by Also needs to pay for canister creation cost.? Is this referring to the fact that out of the attached cycles amount, a certain number of cycles will be used up immediately for the canister creation itself? Do we know the exact amount?
lwshang
added a commit
that referenced
this pull request
May 1, 2026
* chore: wasmtime 43.0.2 * fix(deps): update frontend lockfile to fix security vulnerabilities Addresses Dependabot alert #22 (CVE-2026-27606, GHSA-mw96-cpmx-2vgc): - rollup: 4.52.5 -> 4.60.2 (arbitrary file write via path traversal) Additional vulnerabilities fixed via npm audit fix: - ajv: 6.12.6 -> 6.15.0 (ReDoS with $data option) - brace-expansion: 1.1.12 -> 1.1.14 (ReDoS zero-step sequence) - minimatch: 3.1.2 -> 3.1.5 (ReDoS repeated wildcards) - picomatch: 2.3.1 -> 2.3.2 (method injection / ReDoS) - postcss: 8.5.6 -> 8.5.13 (XSS via unescaped </style>) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(deps): bump vite to 6.4.2 in react example Addresses Dependabot alert #63 (CVE-2026-39365, GHSA-4w7w-66w2-5vf9): path traversal in optimized deps .map handling. All 5.x versions fall within the vulnerable range (<= 6.4.1); 6.4.2 is the patched version. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: exclude example lock files from git to reduce dependabot noise Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(deps): update Cargo.lock with latest dependency versions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(deps): bump postcss to 8.5.13 and yaml to 2.8.3 in docs-site Fixes GHSA-qx2v-qp2m-jg93 (postcss XSS via unescaped </style>) and partially fixes GHSA-48c2-rrv3-qjmp (yaml stack overflow via deeply nested collections). The top-level yaml is now 2.8.3. The nested node_modules/yaml-language-server/node_modules/yaml remains at 2.7.1 because volar-service-yaml@0.0.70 (the latest release) pins yaml-language-server@~1.20.0, which in turn pins yaml@2.7.1 exactly. There is no non-breaking fix available upstream; the chain will resolve once volar-service-yaml ships a release that adopts a newer yaml-language-server. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a PocketIC binary from
masterin the monorepo. To fetch:wget https://download.dfinity.systems/ic/75cc133e4407cfeb94a73dd623dc6f8398ae3c1e/binaries/x86_64-darwin/pocket-ic.gz