feat: initial skeleton for build command by rikonor · Pull Request #7 · dfinity/icp-cli

rikonor · 2025-05-29T16:27:47Z

No description provided.

…tter errors

…nister

Dismissing the change because I did do it manually, I guess Github just couldn't see it. Let me know if I missed something, though!

adamspofford-dfinity

LGTM after this

initial skeleton for build command

e18974b

rikonor self-assigned this May 29, 2025

rikonor requested a review from a team as a code owner May 29, 2025 16:27

rikonor added 2 commits May 29, 2025 12:33

pull project functionality into its own crate

72452ee

create canister and project manifest definitions

d76e032

rikonor changed the title ~~initial skeleton for build command~~ feat: initial skeleton for build command May 29, 2025

ghost reviewed May 29, 2025

View reviewed changes

Comment thread lib/icp-canister/src/lib.rs Outdated

ghost reviewed May 29, 2025

View reviewed changes

Comment thread lib/icp-canister/src/lib.rs Outdated

ghost reviewed May 29, 2025

View reviewed changes

Comment thread lib/icp-project/src/lib.rs Outdated

rikonor added 2 commits May 29, 2025 16:33

add parsing logic for project and canister manifests

45507b8

revert some minor changes

a40140e

adamspofford-dfinity reviewed May 29, 2025

View reviewed changes

Comment thread bin/icp-cli/src/commands/build.rs Outdated

Comment thread bin/icp-cli/src/commands/build.rs Outdated

Comment thread lib/icp-canister/src/lib.rs Outdated

Comment thread Cargo.toml

rikonor added 2 commits May 29, 2025 17:11

put adapter definitions in adapter enum

c6c3de8

clean up snafu errors

14aeab5

ghost reviewed May 29, 2025

View reviewed changes

Comment thread bin/icp-cli/src/commands/build.rs Outdated

rikonor force-pushed the or-build-skeleton branch 2 times, most recently from d8e888b to f91fca4 Compare May 29, 2025 21:43

switch from parsing yaml bytes to taking the path so we can report be…

fd56d1c

…tter errors

rikonor force-pushed the or-build-skeleton branch from f91fca4 to fd56d1c Compare May 29, 2025 21:45

ghost reviewed May 29, 2025

View reviewed changes

Comment thread lib/icp-project/src/lib.rs Outdated

adamspofford-dfinity reviewed May 29, 2025

View reviewed changes

Comment thread lib/icp-project/src/lib.rs Outdated

ghost previously requested changes May 29, 2025

View reviewed changes

rikonor added 2 commits May 30, 2025 09:09

rename error for clarity

f3b4e96

specify path in certain errors

5a905d6

rikonor force-pushed the or-build-skeleton branch from c72a7db to 5a905d6 Compare May 30, 2025 14:23

rikonor added 5 commits May 30, 2025 10:24

remove assets canister variant until it can be further discussed

63b8740

specify explicit defaults for project manifest

8c0ffbb

remove redundant check for file existence

0ea957b

create a load_yaml_file function and use it in icp-project and icp-ca…

dab4ac2

…nister

Merge branch 'main' into or-build-skeleton

8cc67c6

ghost reviewed May 30, 2025

View reviewed changes

Comment thread lib/icp-project/src/lib.rs Outdated

rikonor added 3 commits May 30, 2025 15:30

fix globbing not working from non-project root directory

e5a45e1

move project structure and directory to icp-project module

a67b8f2

extract knowledge of canister yaml path into project directory structure

dcf6c8e

ghost suggested changes Jun 3, 2025

View reviewed changes

rikonor added 3 commits June 3, 2025 10:25

single group imports

372e3ab

use canister manifest path from directory structure

f5d73d3

leaf subcommands should use an exec name and not dispatch

bdd98b7

rikonor force-pushed the or-build-skeleton branch from b696dba to bdd98b7 Compare June 3, 2025 14:36

move everything to model file

00afea2