Conversation
- internet-identity: @dfinity/auth-client → @icp-sdk/auth, @dfinity/agent → @icp-sdk/core - asset-canister: @dfinity/assets → @icp-sdk/canisters, @dfinity/agent → @icp-sdk/core - certified-variables: @dfinity/agent → @icp-sdk/core/agent - vetkd: no change (@dfinity/vetkeys is domain-specific, not yet migrated)
raymondk
added a commit
that referenced
this pull request
Mar 3, 2026
- Merge pitfall #3 (dfx.json vs icp.yaml) into pitfall #1 (dfx vs icp) - Remove multi-canister example (composition of individual examples) - Add candid recipe configuration to Rust and Motoko examples - Add candid to dfx→icp configuration mapping table Co-authored-by: raymondk <raymond.khalife@dfinity.org>
marc0olo
added a commit
that referenced
this pull request
Mar 9, 2026
…vals
- Serve reference files (references/*.md) at /.well-known/skills/{name}/{path}
via a new Astro catch-all route, completing the Skills Discovery RFC chain
- Include files array in /.well-known/skills/index.json for each skill
- Expand icp-cli evaluations from 3 to 12 output evals covering all pitfalls
- Fix eval harness shell expansion bug (execFileSync instead of execSync)
- Add --list flag and numeric --eval index to eval harness
- Correct icp-cli pitfall #3: unpinned recipes are rejected, not just risky
- Document reference file endpoint on Access page and in README
This was referenced Mar 9, 2026
raymondk
added a commit
that referenced
this pull request
Mar 9, 2026
…vals (#81) - Serve reference files (references/*.md) at /.well-known/skills/{name}/{path} via a new Astro catch-all route, completing the Skills Discovery RFC chain - Include files array in /.well-known/skills/index.json for each skill - Expand icp-cli evaluations from 3 to 12 output evals covering all pitfalls - Fix eval harness shell expansion bug (execFileSync instead of execSync) - Add --list flag and numeric --eval index to eval harness - Correct icp-cli pitfall #3: unpinned recipes are rejected, not just risky - Document reference file endpoint on Access page and in README Co-authored-by: raymondk <raymond.khalife@dfinity.org>
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all deprecated
@dfinity/*npm package references to the new@icp-sdk/*packages (released Dec 2025, now at v5.0.0).Changes:
@dfinity/auth-client→@icp-sdk/auth/client,@dfinity/agent→@icp-sdk/core/agent@dfinity/assets→@icp-sdk/canisters/assets,@dfinity/agent→@icp-sdk/core/agent@dfinity/agent→@icp-sdk/core/agent,@dfinity/certificate-verification→@icp-sdk/core/agent@dfinity/vetkeysis domain-specific and hasn't migrated yetAddresses issue #1 item 5 (deprecated packages).
Test plan
npm run build)@dfinity/agent,@dfinity/auth-client,@dfinity/assetsreferences remain@dfinity/vetkeys(domain-specific) should remain