Skip to content

Print histogram values using FormattedValue struct#12

Merged
frederikrothenberger merged 1 commit intodfinity:mainfrom
mbjorkqvist:mathias-print-histogram-values-using-formattedvalue
Feb 23, 2024
Merged

Print histogram values using FormattedValue struct#12
frederikrothenberger merged 1 commit intodfinity:mainfrom
mbjorkqvist:mathias-print-histogram-values-using-formattedvalue

Conversation

@mbjorkqvist
Copy link
Copy Markdown
Contributor

Print the values of histograms using the FormattedValue struct, as is the case for other types. Also adds a test (based on another existing test) verifying that the f64::INFINITY value in a histogram is printed correctly.

Copy link
Copy Markdown

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@frederikrothenberger frederikrothenberger merged commit 1f9a17b into dfinity:main Feb 23, 2024
jasonz-dfinity added a commit that referenced this pull request Feb 26, 2026
## Summary

- Bump version to 1.1.2
- Update CHANGELOG with fix: histogram values now use `FormattedValue`
for consistent encoding of special values (+Inf, -Inf, NaN) (#12)

## After merging

Create a GitHub Release with tag `v1.1.2` targeting `main` to trigger
the automated crates.io publish workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants