-
Notifications
You must be signed in to change notification settings - Fork 8
fix!: use bigint for addCycles and getCyclesBalance
#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
addCycles and getCyclesBalance
Why not using |
@peterpeterparker the PocketIC API doesn't support parsing |
|
Gotcha |
|
@peterpeterparker when parsing a PocketIC server JSON response that contains a bigint, e.g. |
|
Yeah took more time to understand the all PR and third party dependencies and not just the parsing. Thanks for the feedback. |
Uses BigInt for numbers that are actually supposed to be big integers according to the API.
Unfortunately, this fix required using a custom JSON parser and serializer, provided by the json-with-bigint package. Reimplementing it was not worth it. I've pinned the version of the package so that it minimizes the risk of introducing any vulnerabilities with future patches of the package.
Additionally, fixes #193.