feat: add possibility to enter ICP and e8s as amount of cycles to fab…#2154
Merged
viviveevee merged 6 commits intomasterfrom Apr 26, 2022
Merged
feat: add possibility to enter ICP and e8s as amount of cycles to fab…#2154viviveevee merged 6 commits intomasterfrom
viviveevee merged 6 commits intomasterfrom
Conversation
ghost
suggested changes
Apr 26, 2022
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
ghost
approved these changes
Apr 26, 2022
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ricate
dfx ledger fabricate-cyclescan now accept amounts in ICP or e8s, making it a drop-in replacement fordfx ledger top-up. It fetches the current exchange rate from the real IC.Description
extension of #2135
Fixes: SDK-426
How Has This Been Tested?
Manually. Don't know how to mock IC responses within bats.
Checklist: