fix: creating an identity with --force no longer switches to the ne…#2860
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 10, 2023
Conversation
…wly created identity
…ges-selected-identity-to-the-newly-created-identity
ghost
approved these changes
Jan 10, 2023
mergify
Bot
deleted the
SDK-911-dfx-identity-new-force-always-changes-selected-identity-to-the-newly-created-identity
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…wly created identity
Description
#2141 introduced a special case to temporarily switch to the anonymous identity if the currently selected identity gets re-created with
dfx identity new --force. The logic to switch toanonymousand back to the newly created identity mistakenly triggers every time.dfx identity new --forceisn’t supposed to automatically switch to the newly created identity.Fixes SDK-911
How Has This Been Tested?
Added e2e
Checklist: