perf: BTreeMap: make range().count() more efficient#190
Merged
dragoljub-djuric merged 30 commits intomainfrom Feb 14, 2024
Merged
perf: BTreeMap: make range().count() more efficient#190dragoljub-djuric merged 30 commits intomainfrom
range().count() more efficient#190dragoljub-djuric merged 30 commits intomainfrom
Conversation
dragoljub-djuric
commented
Feb 7, 2024
range().count() more efficientrange().count() more efficient
Contributor
Author
|
@ielashi I can add a benchmark to compare it with the previous implementation, but I am not sure that is important. WDYT? |
Contributor
It is absolutely important :) How else will we know that our change has improved anything? |
Contributor
Author
|
@ielashi The bench is added:) |
ielashi
reviewed
Feb 8, 2024
Co-authored-by: Islam El-Ashi <islam.elashi@dfinity.org>
…ange-count-more-efficient
…into Add_iter_count_benches
…ange-count-more-efficient
ielashi
reviewed
Feb 12, 2024
range().count() more efficientrange().count() more efficient
range().count() more efficientrange().count() more efficient
range().count() more efficientrange().count() more efficient
|
ielashi
reviewed
Feb 14, 2024
Co-authored-by: Islam El-Ashi <islam.elashi@dfinity.org>
ielashi
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
BTreeMap::Iterator::count() implicitly uses BTreeMap::Iterator::next() which in some cases loads the map entry's value non-lazy.
Solution:
Explicitly reimplement BTreeMap::Iterator::count() so it does not load the value.