feat: move initialization of StableBTreeMap cursors into Iter#231
Merged
dsarlis merged 9 commits intodfinity:mainfrom Nov 7, 2024
Merged
feat: move initialization of StableBTreeMap cursors into Iter#231dsarlis merged 9 commits intodfinity:mainfrom
StableBTreeMap cursors into Iter#231dsarlis merged 9 commits intodfinity:mainfrom
Conversation
|
dsarlis
reviewed
Oct 18, 2024
Contributor
Author
I'm surprised by the performance regression around inserts since I should have only affected reading and iterating over the map. I'll have a look into it tomorrow though. |
|
Actually, I think we might be seeing a race condition here because around the same time, Islam bumped the canbench version used. By visually comparing the numbers, I think you get pretty much the same after that PR. Yeah, the bot edited the results at some point but not the summary of the comment (still says significant change detected but all results are now within noise, this is a separate issue that we should fix I guess). |
dsarlis
previously approved these changes
Oct 29, 2024
dsarlis
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been doing the work to move all chat events in OpenChat to stable memory, but this required
StableBTreeMapto implementDoubleEndedIteratorsince we need to be able to iterate chat events in either direction.I have implemented this on my own fork (here).
Rather than submit a fairly large PR containing the entire change, I have broken it into 2 deliverable pieces, with this PR being the first one.
Before this PR, the
StableBTreeMapcursors would be initialised before iteration starts, which is fine if you'll always be iterating forwards.But once you can iterate in either direction, it is beneficial to only calculate the cursors for your direction of iteration when required, because if you only iterate in one direction, the cursors for the other direction are never needed.
So all this PR does is delay the initialization of the cursors until the first call to
Iterator::next.