feat: implement keys and values on StableBTreeMap#241
Merged
dsarlis merged 4 commits intodfinity:mainfrom Nov 13, 2024
Merged
Conversation
dsarlis
reviewed
Nov 13, 2024
dsarlis
left a comment
There was a problem hiding this comment.
I feel like it would be a good idea to introduce some benchmarks that cover the new functions added as well, wdyt?
Contributor
Author
Done! |
|
dsarlis
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
keysandvaluestoStableBTreeMapbringing it more in line with the stdBTreeMap.It also adds
keys_rangeandvalues_rangewhich aren't exposed by the stdBTreeMap, with the std map these aren't really needed because the keys and values are returned by reference, so it is still efficient to userangeand thenmapto get the keys or the values.But with the
StableBTreeMapusing the same approach would result in reading and deserializing the keys and values, only to throw one set of them away.