chore: Bump Rust version to 1.78 in rust-toolchain#254
Merged
frankdavid merged 1 commit intomainfrom Dec 2, 2024
Merged
Conversation
A transitive dependency (cargo-platform) has been updated and now requires min Rust version 1.78. Our library can still be used with a lower Rust version but our tests/benchmarks will be run with 1.78.
|
berestovskyy
approved these changes
Dec 2, 2024
Contributor
berestovskyy
left a comment
There was a problem hiding this comment.
Approving to unblock you. We should figure out why, for example, vec_insert_u64 regresses ~5%...
Contributor
Author
I think there are two things at play here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transitive dependency (cargo-platform) has been updated and now requires min Rust version 1.78.
Our library can still be used with a lower Rust version but our tests/benchmarks will be run with 1.78.