Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR splits the existing unified benchmarks into separate per-crate benchmarks, refactors common code into a shared module, and updates the CI workflow to run and collect results for each benchmark crate individually.
- Remove the root-level
canbench.ymland legacy build scripts - Introduce
canbench.ymland result files under each ofbenchmarks/{btreemap,memory_manager,vec} - Refactor
benchmarks/src/common.rs, add acommonmodule, update imports, and extend CI to handle multiple benchmark jobs
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| canbench.yml | Deleted root-level benchmark config |
| benchmarks/src/common.rs | Made Random trait pub, removed now-obsolete mod lines |
| benchmarks/vec/src/main.rs | Updated use path to benchmarks::common::Random, added stub |
| benchmarks/vec/canbench.yml | Added per-crate benchmark config |
| benchmarks/vec/canbench_results.yml | Committed generated benchmark results |
| benchmarks/memory_manager/** | Added per-crate config, results, and main stub |
| benchmarks/btreemap/** | Added per-crate config, results, and main stub |
| benchmarks/Cargo.toml | Defined lib and three [[bin]] entries for each bench binary |
| .github/workflows/ci.yml | Expanded CI to launch benchmark-btreemap, memory-manager, and vec jobs |
Comments suppressed due to low confidence (2)
benchmarks/src/common.rs:1
- These imports (
Blob,FixedVec,Storable) are not used incommon.rsand can be removed to reduce unnecessary dependencies.
use ic_stable_structures::storable::{Blob, FixedVec, Storable};
benchmarks/src/common.rs:2
- The
Randtrait is not used in this file; consider removing it and only importingRng.
use tiny_rng::{Rand, Rng};
|
|
|
michael-weigelt
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the existing benchmarks into separate per-type benchmarks.
It also updates the CI workflow to run and collect results for each benchmark crate individually.