perf: (breaking change) remove excessive cloning in btreemap.insert by maksymar · Pull Request #322 · dfinity/stable-structures

maksymar · 2025-05-26T12:34:58Z

This PR removes excessive cloning in btreemap.insert by adding a new method into_bytes to Memory trait.

Google sheets CSV reports link.

github-actions · 2025-05-26T13:57:01Z

`canbench` 🏋 (dir: ./benchmarks/btreemap) `223ea88` 2025-06-12 16:22:32 UTC

✅ ./benchmarks/btreemap/canbench_results.yml is up to date
📦 canbench_results_btreemap.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   Improvements detected 🟢
    counts:   [total 285 | regressed 0 | improved 14 | new 0 | unchanged 271]
    change:   [max +630 | p75 0 | median 0 | p25 -15 | min -838.88M]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 -0.00% | min -15.97%]

  heap_increase:
    status:   Improvements detected 🟢
    counts:   [total 285 | regressed 0 | improved 1 | new 0 | unchanged 284]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min -161]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min -50.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 285 | regressed 0 | improved 0 | new 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------

Only significant changes:
| status | name                                      | calls |     ins |  ins Δ% |  HI |   HI Δ% |   SMI |  SMI Δ% |
|--------|-------------------------------------------|-------|---------|---------|-----|---------|-------|---------|
|   -    | btreemap_v2_insert_u64_vec8               |       | 417.79M |  -2.16% |   0 |   0.00% |    21 |   0.00% |
|   -    | btreemap_v2_insert_vec_32_512             |       | 969.86M |  -2.79% |   0 |   0.00% |    91 |   0.00% |
|   -    | btreemap_v2_range_count_1k_10kib          |       |   2.58M |  -2.83% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_scan_keys_rev_1k_10kib        |       |   2.49M |  -3.37% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_scan_keys_1k_10kib            |       |   2.51M |  -3.41% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_mem_manager_insert_u64_vec512 |       | 843.36M |  -3.59% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_insert_vec_32_1024            |       |   1.17B |  -4.00% |   0 |   0.00% |   171 |   0.00% |
|   -    | btreemap_v2_scan_iter_rev_1k_0b           |       |   1.38M |  -5.11% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_scan_iter_1k_0b               |       |   1.38M |  -5.19% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_scan_values_rev_1k_0b         |       |   1.36M |  -5.19% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_scan_values_1k_0b             |       |   1.36M |  -5.27% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_scan_keys_rev_1k_0b           |       |   1.11M |  -7.32% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_scan_keys_1k_0b               |       |   1.10M |  -7.47% |   0 |   0.00% |     0 |   0.00% |
|   -    | btreemap_v2_insert_10mib_values           |       |   4.41B | -15.97% | 161 | -50.00% | 3.61K |   0.00% |

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2025-05-26T13:57:02Z

`canbench` 🏋 (dir: ./benchmarks/vec) `223ea88` 2025-06-12 16:20:53 UTC

✅ ./benchmarks/vec/canbench_results.yml is up to date
📦 canbench_results_vec.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   Improvements detected 🟢
    counts:   [total 16 | regressed 0 | improved 1 | new 0 | unchanged 15]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min -510.00K]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min -8.69%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------

Only significant changes:
| status | name           | calls |   ins |  ins Δ% | HI |  HI Δ% | SMI |  SMI Δ% |
|--------|----------------|-------|-------|---------|----|--------|-----|---------|
|   -    | vec_insert_u64 |       | 5.36M |  -8.69% |  0 |  0.00% |   1 |   0.00% |

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2025-05-26T13:57:03Z

`canbench` 🏋 (dir: ./benchmarks/memory_manager) `223ea88` 2025-06-12 16:20:40 UTC

✅ ./benchmarks/memory_manager/canbench_results.yml is up to date
📦 canbench_results_memory-manager.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2025-05-27T07:45:52Z

`canbench` 🏋 (dir: ./benchmarks/compare) `223ea88` 2025-06-12 16:21:44 UTC

✅ ./benchmarks/compare/canbench_results.yml is up to date
📦 canbench_results_compare.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   Improvements detected 🟢
    counts:   [total 18 | regressed 0 | improved 4 | new 0 | unchanged 14]
    change:   [max +3.00M | p75 +5 | median 0 | p25 -419.17M | min -1.44B]
    change %: [max +0.08% | p75 0.00% | median 0.00% | p25 -1.46% | min -39.18%]

  heap_increase:
    status:   Improvements detected 🟢
    counts:   [total 18 | regressed 0 | improved 2 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min -1.60K]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min -49.43%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------

Only significant changes:
| status | name                     | calls |     ins |  ins Δ% |    HI |   HI Δ% |   SMI |  SMI Δ% |
|--------|--------------------------|-------|---------|---------|-------|---------|-------|---------|
|   -    | read_chunks_btreemap_1k  |       |   4.99B |  -7.77% | 1.60K |  -0.12% | 1.67K |   0.00% |
|   -    | write_chunks_btreemap_1k |       |   4.49B |  -8.56% | 1.60K |  -0.12% | 1.67K |   0.00% |
|   -    | read_chunks_btreemap_1   |       | 799.99M | -34.38% | 1.64K | -49.43% | 1.67K |   0.00% |
|   -    | write_chunks_btreemap_1  |       | 650.63M | -39.18% | 1.64K | -49.43% | 1.67K |   0.00% |

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2025-06-11T08:06:11Z

`canbench` 🏋 (dir: ./benchmarks/btreeset) `223ea88` 2025-06-12 16:21:01 UTC

✅ ./benchmarks/btreeset/canbench_results.yml is up to date
📦 canbench_results_btreeset.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max +511.24K | p75 +3.99K | median +36 | p25 +24 | min -5.76M]
    change %: [max +0.04% | p75 0.01% | median 0.00% | p25 0.00% | min -1.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

maksymar added 16 commits May 26, 2025 14:32

fix build

84fe979

.

1cdce5a

--persist

856e5fb

.

1ef691c

.

c447cbd

.

1a589d5

.

3e5105f

.

8cba39b

clippy

fada070

clippy

6d44b38

fix build

e8b77d6

.

04328a1

cleanup

06f1ae8

fix doc tests

93a86e5

fix build

3c35ba3

Merge branch 'main' into maksym/into_bytes

510f77f

Merge branch 'main' into maksym/into_bytes

38fa628

maksymar added 9 commits May 27, 2025 21:30

merge main

63ab429

--persist

819d53d

merge main

31cd9ce

fix build

11f4e59

--persist

5eceaed

merge main

2e21305

--persist

1617adc

Merge branch 'main' into maksym/into_bytes

f32fa75

--persist

70a0b66

maksymar added 6 commits June 5, 2025 14:18

merge main

006f232

--persist

495700c

merge main

d4c9264

--persist

1df5f11

merge main

6864a80

--persist

e1c3a8e

maksymar added 4 commits June 12, 2025 09:17

merge main

ede52aa

--persist

05a0b1e

merge main

aa365c3

--persist

799af70

maksymar changed the title ~~perf: remove excessive cloning in btreemap.insert~~ perf: (breaking change) remove excessive cloning in btreemap.insert Jun 12, 2025

maksymar marked this pull request as ready for review June 12, 2025 12:57

maksymar requested a review from a team as a code owner June 12, 2025 12:57

maksymar requested a review from Copilot June 12, 2025 12:58

Copilot AI reviewed Jun 12, 2025

View reviewed changes

dsarlis approved these changes Jun 12, 2025

View reviewed changes

dsarlis reviewed Jun 12, 2025

View reviewed changes

Comment thread src/storable.rs Outdated

maksymar enabled auto-merge (squash) June 12, 2025 14:48

fix comment

a092423

maksymar merged commit 3f6c0c7 into main Jun 12, 2025
16 checks passed

maksymar deleted the maksym/into_bytes branch June 12, 2025 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: (breaking change) remove excessive cloning in btreemap.insert#322

perf: (breaking change) remove excessive cloning in btreemap.insert#322
maksymar merged 37 commits intomainfrom
maksym/into_bytes

maksymar commented May 26, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 27, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

maksymar commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/btreemap) 223ea88 2025-06-12 16:22:32 UTC

Uh oh!

github-actions Bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/vec) 223ea88 2025-06-12 16:20:53 UTC

Uh oh!

github-actions Bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/memory_manager) 223ea88 2025-06-12 16:20:40 UTC

Uh oh!

github-actions Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/compare) 223ea88 2025-06-12 16:21:44 UTC

Uh oh!

github-actions Bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/btreeset) 223ea88 2025-06-12 16:21:01 UTC

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maksymar commented May 26, 2025 •

edited

Loading

github-actions Bot commented May 26, 2025 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/btreemap) `223ea88` 2025-06-12 16:22:32 UTC

github-actions Bot commented May 26, 2025 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/vec) `223ea88` 2025-06-12 16:20:53 UTC

github-actions Bot commented May 26, 2025 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/memory_manager) `223ea88` 2025-06-12 16:20:40 UTC

github-actions Bot commented May 27, 2025 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/compare) `223ea88` 2025-06-12 16:21:44 UTC

github-actions Bot commented Jun 11, 2025 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/btreeset) `223ea88` 2025-06-12 16:21:01 UTC