You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR refactors the internal storage of BTreeMap nodes by renaming the keys_and_encoded_values field to entries and updating all related references across versioned implementations.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the internal storage of BTreeMap nodes by renaming the keys_and_encoded_values field to entries and updating all related references across versioned implementations.
Rename keys_and_encoded_values to entries in node.rs, node/v1.rs, and node/v2.rs
Update loops, asserts, methods, and struct initializers to use entries
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File
Description
src/btreemap/node/v2.rs
Renamed keys_and_encoded_values to entries and updated related loops and struct fields in V2
src/btreemap/node/v1.rs
Renamed keys_and_encoded_values to entries and updated related loops and struct fields in V1
src/btreemap/node.rs
Renamed struct field and all method accesses from keys_and_encoded_values to entries
Comments suppressed due to low confidence (1)
src/btreemap/node/v2.rs:153
EAGER_LOAD_KEY_SIZE_THRESHOLD is defined but never used; consider removing this constant or applying it to gate eager key loading logic.
canbench 🏋 (dir: ./benchmarks/compare) 4957a42 2025-06-05 08:11:47 UTC
✅ ./benchmarks/compare/canbench_results.yml is up to date
📦 canbench_results_compare.csv available in artifacts
---------------------------------------------------
Summary:
instructions:
status: No significant changes detected 👍
counts: [total 18 | new 0 | improved 0 | regressed 0 | unchanged 18]
change: [max +53.05M | p75 0 | median 0 | p25 0 | min -8.77K]
change %: [max +0.06% | p75 0.00% | median 0.00% | p25 0.00% | min -0.00%]
heap_increase:
status: No significant changes detected 👍
counts: [total 18 | new 0 | improved 0 | regressed 0 | unchanged 18]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes detected 👍
counts: [total 18 | new 0 | improved 0 | regressed 0 | unchanged 18]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
CSV results saved to canbench_results.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the internal storage of
BTreeMapnodes by renaming thekeys_and_encoded_valuesfield toentriesand updating all related references across versioned implementations.