refactor: relocate vec types for benchmarks#336
Merged
Conversation
maksymar
changed the title
maksymar
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the benchmarks to remove the dependency on test types by introducing local copies of UnboundedVecN and BoundedVecN. Key changes include:
- Updating import statements to reference the new random and vec modules.
- Adding a new module (benchmarks/src/vec.rs) that defines UnboundedVecN and BoundedVecN.
- Adjusting benchmark files (compare and btreemap) to use the new type definitions.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| benchmarks/vec/src/main.rs | Updated import for the Random trait. |
| benchmarks/src/vec.rs | Added new file defining UnboundedVecN and BoundedVecN types. |
| benchmarks/src/random.rs | Updated imports to use local vec types. |
| benchmarks/src/lib.rs | Updated module declarations. |
| benchmarks/compare/src/main.rs | Adjusted import of BoundedVecN to use new local definitions. |
| benchmarks/btreemap/src/main.rs | Updated imports to reference local definitions and Random trait. |
maksymar
changed the title
|
|
|
|
michael-weigelt
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the benchmarks to remove the dependency on test types by introducing local copies of
UnboundedVecNandBoundedVecN.Copies of those types allow to run stable-structures version before those types were introduced. This change was tested on stable-structures v0.6.7.