Skip to content

refactor: rename 'compare' benchmark to 'io_chunks' for clarity#368

Merged
maksymar merged 5 commits intomainfrom
maksym/compare
Jul 10, 2025
Merged

refactor: rename 'compare' benchmark to 'io_chunks' for clarity#368
maksymar merged 5 commits intomainfrom
maksym/compare

Conversation

@maksymar
Copy link
Copy Markdown
Contributor

@maksymar maksymar commented Jul 10, 2025

Renames the compare benchmark folder to io_chunks to better describe what the benchmark actually does.

Why the rename:

  • compare was too generic and didn't indicate what was being compared
  • io_chunks clearly describes the benchmark's focus on I/O operations with varying chunk sizes

This PR temporarily removes io_chunks from CI benchmark job, because current main branch does not have it at makes the job fail. It will be re-enabled in the follow-up PR.

@maksymar maksymar requested a review from Copilot July 10, 2025 10:44
@maksymar maksymar changed the title refactor: rename compare benchmarks to io_chunks refactor: rename 'compare' benchmark to 'io_chunks' for clarity Jul 10, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Renames the compare benchmark to io_chunks for better clarity, updates the benchmark’s binary configuration, CI workflow, and adds a descriptive header to its main file.

  • Add documentation header in main.rs for the I/O chunks benchmark
  • Update Cargo.toml to rename the binary from compare to io_chunks
  • Update CI workflow to run io_chunks instead of compare

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
benchmarks/io_chunks/src/main.rs Added top‐level doc comments describing the benchmark
benchmarks/Cargo.toml Renamed compare binary to io_chunks
.github/workflows/ci.yml Swapped out CI entries for the new io_chunks target

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 10, 2025

canbench 🏋 (dir: ./benchmarks/memory_manager) d0bdd8b 2025-07-10 11:03:37 UTC

./benchmarks/memory_manager/canbench_results.yml is up to date
📦 canbench_results_memory-manager.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 10, 2025

canbench 🏋 (dir: ./benchmarks/vec) d0bdd8b 2025-07-10 11:03:43 UTC

./benchmarks/vec/canbench_results.yml is up to date
📦 canbench_results_vec.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@maksymar maksymar marked this pull request as ready for review July 10, 2025 11:00
@maksymar maksymar requested a review from a team as a code owner July 10, 2025 11:00
@github-actions
Copy link
Copy Markdown

canbench 🏋 (dir: ./benchmarks/btreeset) d0bdd8b 2025-07-10 11:03:51 UTC

./benchmarks/btreeset/canbench_results.yml is up to date
📦 canbench_results_btreeset.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link
Copy Markdown

canbench 🏋 (dir: ./benchmarks/btreemap) d0bdd8b 2025-07-10 11:05:20 UTC

./benchmarks/btreemap/canbench_results.yml is up to date
📦 canbench_results_btreemap.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 285 | regressed 0 | improved 0 | new 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 285 | regressed 0 | improved 0 | new 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 285 | regressed 0 | improved 0 | new 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@maksymar maksymar merged commit f56a3e9 into main Jul 10, 2025
15 checks passed
@maksymar maksymar deleted the maksym/compare branch July 10, 2025 11:23
maksymar added a commit that referenced this pull request Jul 10, 2025
This PR re-enables `io_chunks` benchmark in the CI.

This is a follow-up PR after
#368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants