Conversation
maksymar
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces NNS vote cascading benchmarks and supporting tests to the repository.
- Adds unit tests for
calculate_cascaded_votescovering various followee configurations and both storage backends. - Implements benchmark setup strategies (Centralized, SingleVote, Chain) with numerous
#[bench]functions to measure performance. - Updates project configuration (
Cargo.toml,canbench.yml) and adds a main binary entry point for NNS benchmarks.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| benchmarks/nns/src/nns_vote_cascading/tests.rs | Added unit tests for vote cascading with Stable/Heap stores |
| benchmarks/nns/src/nns_vote_cascading/benches.rs | Defined benchmark setup strategies and registered benches |
| benchmarks/nns/src/nns_vote_cascading.rs | Implemented Vote, NeuronStore trait, stores, and logic |
| benchmarks/nns/src/main.rs | Added empty main to register NNS benchmark binary |
| benchmarks/nns/canbench_results.yml | Committed initial benchmark results |
| benchmarks/nns/canbench.yml | Added Canbench build and path configurations |
| benchmarks/Cargo.toml | Registered new nns binary for benchmarks |
Comments suppressed due to low confidence (2)
benchmarks/nns/src/nns_vote_cascading/benches.rs:27
- The parameter name 'stratygy' is misspelled; consider renaming it to 'strategy' for clarity.
stratygy: SetUpStrategy,
benchmarks/nns/src/nns_vote_cascading/benches.rs:160
- The parameter name 'stratygy' is misspelled here as well; update it to 'strategy' to match standard spelling.
fn bench_helper(neuron_store: &mut impl NeuronStore, stratygy: SetUpStrategy) -> BenchResult {
|
|
|
|
|
berestovskyy
approved these changes
Jul 14, 2025
Contributor
berestovskyy
left a comment
berestovskyy
left a comment
There was a problem hiding this comment.
Looks good, thanks! Would be nice to also have a Jira reference.
maksymar
added a commit
that referenced
this pull request
Jul 14, 2025
This PR re-enables `nns` benchmark in the CI. This is a follow-up PR after #371.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds NNS related benchmarks.
Based on this code.
NNS benchmarks will be enabled in CI in follow-up PR, because they need to be present in
mainbranch first.