Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds random data support for candid::Principal and unit type, and extends BTreeMap benchmarks to include Principal keys/values and zero-length value cases. Key changes:
- Implemented
RandomforPrincipaland()inrandom.rs. - Introduced
Emptyalias and added numerousbench_tests!entries inmain.rsfor zero-length andPrincipalscenarios. - Updated
canbench_results.ymlwith new benchmark results for the added tests.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| benchmarks/src/random.rs | Added Random impls for Principal and unit () types. |
| benchmarks/btreemap/src/main.rs | Added Empty alias and new bench_tests! cases for Principal and zero-length values. |
| benchmarks/btreemap/canbench_results.yml | Updated YAML with results for the new benchmarks. |
Comments suppressed due to low confidence (3)
benchmarks/src/random.rs:51
- Add unit tests for the
Randomimplementation ofPrincipalto verify generated principals are valid and withinMAX_LENGTH_IN_BYTES.
impl Random for Principal {
benchmarks/src/random.rs:62
- Add a basic test for the
Randomimpl of()to ensure it always returns()as expected.
impl Random for () {
benchmarks/btreemap/src/main.rs:31
- [nitpick] The alias
Emptyis very generic; consider renaming it to something likeUnitValueorEmptyValuefor clearer intent.
type Empty = ();
|
|
|
|
|
|
berestovskyy
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarks for
Principaltype toBTreeMap.