Null I18n#1
Conversation
|
@isaacseymour thanks for the PR, awesome job! I also think it does the job pretty well to avoid the dependency. My only concern is that the |
|
That's exactly my concern, but don't think there's any other way of avoiding the dependency :( |
|
Hey @avit, we're also waiting for your input here. This looks like a viable solution for the concern about dependencies you mentioned here: ice-cube-ruby#273 |
|
@seejohnrun we're also waiting for some input here. Thanks for having a look! |
|
Would love to see this merged. @seejohnrun / @avit - do you have a moment to review? |
|
@greysteil I should be able to get to it at some point this week! |
|
I had a 👶 ! |
|
@seejohnrun - congrats! Everything's now in ice-cube-ruby#311 |
@dgilperez @avit this adds a wrapper around
I18n(IceCube::I18n) which attempts to require in the real library, and delegate to that, but usesIceCube::NullI18ninstead if that fails, which implements the very very basics of the real library's interpolation logic to get by. I don't hugely like it but it does get rid of the runtime dependency.