Fix HTTP/2 build error by implementing RoundTripper adapter#71
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the HTTP/2 build error by introducing a new RoundTripper adapter that wraps the client's Do method, ensuring compatibility with the updated fasthttp modifications.
- Introduces a new clientAdapter type implementing the RoundTrip method
- Updates the HTTP client configuration to use the new adapter
Comments suppressed due to low confidence (2)
configure.go:20
- Consider documenting why the adapter always returns false for the retry flag to clarify that retries are not supported via this adapter.
func (ca *clientAdapter) RoundTrip(hc *fasthttp.HostClient, req *fasthttp.Request, resp *fasthttp.Response) (retry bool, err error) {
configure.go:21
- Ensure the clientAdapter behavior is covered by tests to verify correct error propagation from ca.client.Do.
err = ca.client.Do(req, resp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should allow everything to remain the exact same while being compatible with the new fasthttp modifications.