Fixing httpx.ReadTimeout handling in core.py#6
Merged
Conversation
retry after 5 seconds: useful when httpx read timeout
added retry dep
Owner
|
Thanks for your contribution .. checking .. |
dgunning
approved these changes
Feb 22, 2023
Owner
dgunning
left a comment
dgunning
left a comment
There was a problem hiding this comment.
Looks fairly straightforward. Will merge and test
baqamisaif
pushed a commit
to baqamisaif/edgartools
that referenced
this pull request
Dec 27, 2025
This commit addresses 6 priority improvements to edgar/llm.py: - Fix Issue dgunning#1: extract_sections() now returns list when track_filtered=False (was incorrectly returning tuple, breaking API contract) - Fix Issue dgunning#2: Refactor tools.llm_extraction to edgar.llm_extraction (moves extract_item_with_boundaries to packaged module) - Fix Issue dgunning#3: Remove dead code _STATEMENT_KEYWORDS constant - Fix Issue dgunning#4: Add comprehensive type hints to all private functions - Fix Issue dgunning#5: Upgrade error messages from debug to warning level - Fix Issue dgunning#6: Add unit tests for return type contracts Breaking change fix: Users relying on default behavior now get list instead of (list, {}) tuple, matching documented API contract. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
15 tasks
sangicook
pushed a commit
to sangicook/edgartools
that referenced
this pull request
Apr 6, 2026
6 amendments from advocate/critic/deepthinker consensus (8/10 confidence): - companies.yaml read-only during expansion (pre-populate + JSON migration) - Per-root-cause confidence thresholds (not single 0.90) - Archetype gap detection in /expand-cohort - Pre-expansion override cleanup (promote industry patterns) - Pattern detection in /investigate-gaps (3+ same-industry fixes) - Priority queue (group gaps by metric+industry, highest leverage first) - Success criterion dgunning#6: verified within 3 outer-loop iterations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Congrats to this great project!
I've been getting some httpx.ReadTimeouts while trying to fetch data from the SEC. To handle these, I've added the retry wrapper from the retry package which retries after 2 seconds until the connection works. I've also added the dependency to pyproject.toml