Support for older submissions for companies#7
Merged
Conversation
This makes older submissions available for companies
sangicook
pushed a commit
to sangicook/edgartools
that referenced
this pull request
Apr 6, 2026
… case Address review comment dgunning#7 (Minor) on PR dgunning#764 Sub-project A. The original zero-division test only asserted ``ef_cqs_strict == 0.0`` in an all- unverified cohort, which would pass even if the strict denominator math were broken (numerator is also 0 in that state). That's necessary but insufficient coverage. Strengthened to two cases within the same test: Case A (unchanged intent) — all-unverified degenerate state: Guards ef_cqs AND ef_cqs_strict both return 0.0 without raising. Case B (new) — 1 passing + 1 explained_variance + 1 unverified: effective_total = 3 - 0 - 1 - 1 = 1 → lenient ef_cqs = 1/1 = 1.0 strict_total = 3 - 0 - 1 = 2 → strict ef_cqs_strict = 1/2 = 0.5 Case B would fail loudly if the strict denominator forgot to subtract unverified_count, or accidentally subtracted explained_variance_count (turning it into the lenient formula). The two cases together pin the full contract: guard correctness + arithmetic correctness. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes older submissions available for companies