(KTS) add ml_stats and ml_cross_stats classes to quicklens/sims/util.py#5
Open
kstory8 wants to merge 1 commit intodhanson:masterfrom
Open
(KTS) add ml_stats and ml_cross_stats classes to quicklens/sims/util.py#5kstory8 wants to merge 1 commit intodhanson:masterfrom
kstory8 wants to merge 1 commit intodhanson:masterfrom
Conversation
dhanson
approved these changes
Nov 1, 2017
Owner
dhanson
left a comment
dhanson
left a comment
There was a problem hiding this comment.
LGTM modulo some nit comments.
|
|
||
| class ml_cross_stats(): | ||
| ''' | ||
| Class to gater stats from a cross-spectrum. |
|
|
||
| class ml_stats(): | ||
| ''' | ||
| Gather spectrum statistics |
Owner
There was a problem hiding this comment.
use consistent comment format w/ other functions in the file?
| ''' | ||
| Class to gater stats from a cross-spectrum. | ||
| This emulates sims.util.ml_stats() | ||
| ''' |
Owner
There was a problem hiding this comment.
A lot of the code here is identical to that in ml_stats -- WDYT about using it as a base class?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dhanson Can you take a look and merge this pull request? I simply copied over the classes we built a few years ago.