fix: [ANDROAPP-7569] Correct metadata settings refresh#4792
Merged
Conversation
…c metadata settings triggered when job is set to manual initially
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to correct how metadata sync settings are refreshed and how background jobs are (re)scheduled when the metadata sync period changes (notably around “Manual” mode).
Changes:
- Make
SyncRepository.currentMetadataSyncPeriod()nullable and propagate nullability into domain logic. - Adjust job scheduling to handle nullable sync periods when launching metadata sync.
- Increase the periodic cadence for
SyncSettingsWorkerfrom daily to hourly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sync/src/commonMain/kotlin/org/dhis2/mobile/sync/domain/SyncSettings.kt | Updates “changed from manual” detection and rescheduling logic using nullable metadata period. |
| sync/src/commonMain/kotlin/org/dhis2/mobile/sync/domain/SyncMetadata.kt | Updates metadata period-change handling to accept nullable periods and reschedule accordingly. |
| sync/src/commonMain/kotlin/org/dhis2/mobile/sync/data/SyncRepository.kt | Changes currentMetadataSyncPeriod() contract to return SyncPeriod?. |
| sync/src/androidMain/kotlin/org/dhis2/mobile/sync/data/AndroidSyncBackgroundJobAction.kt | Changes sync-settings periodic work interval from 1 day to 1 hour. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Balcan
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link the JIRA issue.
Please provide a clear definition of the problem and explain your solution.