chore: replace travis with github actions#855
Merged
Conversation
paschalidi
reviewed
Nov 27, 2020
paschalidi
reviewed
Nov 27, 2020
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "prebuild": "(rm -r build && mkdir build) || mkdir build", | ||
| "build": "webpack && cp -r i18n build/i18n && cp -r core build/core && cp -r vendor build/vendor && cp -r views build/views && cp -r styles build/styles && find ./components -iname \"*.html\" -exec rsync -R '{}' ./build/ \\;", | ||
| "build": "webpack && cp package.json build && cp -r i18n build/i18n && cp -r core build/core && cp -r vendor build/vendor && cp -r views build/views && cp -r styles build/styles && find ./components -iname \"*.html\" -exec rsync -R '{}' ./build/ \\;", |
There was a problem hiding this comment.
What does this help you achieve? I am asking because I cant think why we need to change the build function.
Member
Author
There was a problem hiding this comment.
Me neither, I added it because the script for bundling apps seems to look for it as part of the bundling process. I can remove it again as it seems this will work without it as well.
Member
Author
There was a problem hiding this comment.
You can perhaps ave a look at this line in git.js(114) in dhis2-core:
const pkg_name = require(path.join(clone_path, 'package.json')).name
There was a problem hiding this comment.
Okay. I would remove this cp command if everything works without it as well, but you can be the judge of it :)
Member
Author
There was a problem hiding this comment.
I see most other apps are including package.json, so I'll leave this in.
Contributor
|
🎉 This PR is included in version 31.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Bekkalizer
added a commit
that referenced
this pull request
Dec 1, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 1, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 1, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
* chore: replace travis with github actions * fix: build path and include package.json * chore: removed comments
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
Bekkalizer
added a commit
that referenced
this pull request
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.