feat: Native axum executor integration#152
Draft
yulnr wants to merge 4 commits into
Draft
Conversation
Now that axum supports Serve::with_executor(), implement axum::serve::Executor directly on TelemetryHandle behind an "axum" feature flag.
341bf00 to
471fc4e
Compare
✅ Deploy Preview for dial9-tokio-telemetry canceled.
|
yulnr
commented
Apr 1, 2026
| axum::serve(listener, app.into_make_service()) | ||
| .with_executor(handle.clone()) | ||
| .with_graceful_shutdown(async move { shutdown.cancelled().await }) | ||
| .await |
Collaborator
Author
There was a problem hiding this comment.
this unwrap diff is unrelated, unwrap no longer needed due to API change upstream
yulnr
commented
Apr 1, 2026
| /// Implement `axum::serve::Executor` for `TelemetryHandle` to allow it to be | ||
| /// used as an executor for axum's serve. | ||
| #[cfg(feature = "axum")] | ||
| impl axum::serve::Executor for TelemetryHandle { |
Collaborator
Author
There was a problem hiding this comment.
Alternatively we could newtype this or have a struct that has the handle as field and impl axum::serve::Executor for it. This seemed the simplest for users.
Contributor
There was a problem hiding this comment.
I'd probably rather have this as the 10 lines of code we need in application crates rather than putting it in core for now.
e.g. if we have multiple versions of axum etc. etc. this just becomes kind a headache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #62
Implements the new
axum::serve::ExecutoronTelemetryHandlebehindfeatures = ["axum"]Deletes
axum_traced.rs(previous hand-rolled serve loop) and simplifies metrics-service example to useaxum::servedirectly.Depends on this being released: tokio-rs/axum#3704
Before
Users had to reimplement axum's serve loop to inject traced task spawning:
After