Conversation
Eventually I want to try migrating GMRA to React so we can more easily manage application state and all the different button components. Automated testing should help take some of the pain out of this. I chose the cypress framework because it seemed like the easiest to set up for testing extensions.
TIL that checking in node_modules is generally not a good idea. Added a .gitignore template that covers this and more. I guess download/contributing instructions will have to change? I'm not yet sure how exactly, though.
TIL that checking in node_modules is generally not a good idea. Added a .gitignore template that covers this and more. I guess download/contributing instructions will have to change? I'm not yet sure how exactly, though.
Also gets rid of some files I accidentally created in this branch (buttons.js and popup.js)
emlabor
commented
Aug 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull request template
about: GenderMag Recorders Assistant project
Cypress will allow us to automate tests that we used to run manually with Chrome Dev Tools, speeding up development.
No.
Only Mac, although I didn't change any of the source code so things should be fine.
Yes.
Running sample.spec.js in Cypress
Apologies that this is one really big commit. I meant to add the actual tests separately but due to some rollbacks I did to get Git Large File Storage working, it all got lumped into one. Sample.spec.js contains a draft test for going through the pre-walkthrough, which needs to be executed before other debugging can begin.