Fix incorrect unique item name casing - BloodSlayer

[kphoenix137]

BloodSlayer -> Bloodslayer

[NiteKat]

Is this meant to be two words instead of one, kind of how we had Red Vex but BlackJade in 1.09? Should the correction here be to change this to Blood Slayer instead of Bloodslayer? Bloodslayer isn't a word.

[kphoenix137]

Is this meant to be two words instead of one, kind of how we had Red Vex but BlackJade in 1.09? Should the correction here be to change this to Blood Slayer instead of Bloodslayer? Bloodslayer isn't a word.

Stonecleaver, Crackrust, Thundercall, etc.

[kphoenix137]

Is this meant to be two words instead of one, kind of how we had Red Vex but BlackJade in 1.09? Should the correction here be to change this to Blood Slayer instead of Bloodslayer? Bloodslayer isn't a word.

Stonecleaver, Crackrust, Thundercall, etc.

[NiteKat]

Is this meant to be two words instead of one, kind of how we had Red Vex but BlackJade in 1.09? Should the correction here be to change this to Blood Slayer instead of Bloodslayer? Bloodslayer isn't a word.

Stonecleaver, Crackrust, Thundercall, etc.

While good examples to counter Bloodslayer not being a word, it still feels inconsistent with how BlackJade was modified to Black Jade and not Blackjade, no? Though, that was a unique monster name and not an item name, so maybe it doesn't have to be consistent between the two. Just pointing it out as something to think about for whomever reviews the PR I guess.

[kphoenix137]

Is this meant to be two words instead of one, kind of how we had Red Vex but BlackJade in 1.09? Should the correction here be to change this to Blood Slayer instead of Bloodslayer? Bloodslayer isn't a word.

Stonecleaver, Crackrust, Thundercall, etc.

While good examples to counter Bloodslayer not being a word, it still feels inconsistent with how BlackJade was modified to Black Jade and not Blackjade, no? Though, that was a unique monster name and not an item name, so maybe it doesn't have to be consistent between the two. Just pointing it out as something to think about for whomever reviews the PR I guess.

I'm not sure why BlackJade was changed to Black Jade. It makes more sense to keep it as Blackjade because there was no case difference in vanilla and players read it as BLACKJADE. Problems like these are only visible in DevilutionX.

[StephenCWills]

I'm not sure why BlackJade was changed to Black Jade.

It was almost certainly because "Black Jade" is more consistent with "Red Vex" than "Blackjade". On that note, "Bloodslayer" is more consistent with "Hellslayer" than "Blood Slayer".