Skip to content

Stale PR triage: valuable work from bradygaster/squad to pick up #137

@diberry

Description

@diberry

Stale PR Triage — Valuable Work from bradygaster/squad

Flight triaged 13 stale PRs (5-7 days old, zero reviews) from bradygaster/squad. This issue tracks items worth picking up on diberry/squad.

Evaluation Criteria

  • Does it fix a real bug users hit?
  • Does it unblock other features or improve reliability?
  • Is the work complete and well-scoped?

🟢 Pick Up — Valuable, Actionable Work

PR Title What Needs to Happen Squad Owner
#675 feat(cli): remove REPL, add deprecation message Major cleanup: removes 26K lines of shell code with persistent rendering issues. Needs rebase onto current dev. Product direction decision by repo owner. VOX 🖥️ + EECOM 🔧
#682 feat(coordinator): compaction recovery via session-state.md Fixes bradygaster#653 — long sessions lose all context during compaction. Prompt-only change (2 files). Cherry-pick and validate. Procedures 🧠
#683 Add Coordinator Restraint rules (bradygaster#587) Fixes bradygaster#587 — coordinator over-manages agents, adds noise. Prompt + routing change (5 files). Cherry-pick and validate. Procedures 🧠
#684 fix(coordinator): persist agent results immediately after read_agent Fixes bradygaster#652 — read_agent results expire silently in 2-3 min during fan-out. Adds mandatory persistence step. 4 template files. Procedures 🧠
#704 fix(cli): warn when squad watch receives unused message args Fixes bradygaster#703 — users pass messages to squad watch which silently ignores them. 10-line UX fix in cli-entry.ts. EECOM 🔧
#713 fix(docs): re-initialize search after Astro View Transitions Fixes bradygaster#712 — docs site search breaks after navigation. Includes 2 Playwright regression tests. Community contribution (CarlosSardo). PAO 📣
#715 Fix bradygaster#711: squad start --tunnel validates node-pty before side effects Prevents terminal corruption when node-pty is missing. Defensive validation with informative error. Community contribution (andikrueger). EECOM 🔧
#722 fix(ci): add build step to insider publish test job 1-file CI fix — test job does fresh checkout without dist/, causing ERR_MODULE_NOT_FOUND. Trivial fix. Booster ⚙️
#723 fix(test): Docker skip guards + flaky test stabilization Closes bradygaster#677, fixes bradygaster#582 — Docker-dependent tests fail without Docker. Shared skip guard helper + timeout fixes. Supersedes bradygaster#679. FIDO 🧪

Priority Order

  1. fix(ci): add build step to insider publish test job bradygaster/squad#722 (CI fix) — trivial, unblocks insider publish pipeline
  2. fix(test): Docker skip guards + flaky test stabilization (#677) bradygaster/squad#723 (flaky tests) — improves CI reliability for everyone
  3. fix(cli): warn when squad watch receives unused message args (#703) bradygaster/squad#704 (watch warning) — small UX fix, easy win
  4. fix(docs): re-initialize search after Astro View Transitions bradygaster/squad#713 (docs search) — user-facing docs bug with tests included
  5. Fix issue #711: squad start --tunnel validates node-pty before side effects bradygaster/squad#715 (node-pty validation) — prevents terminal corruption
  6. Add Coordinator Restraint rules (#587) bradygaster/squad#683 (coordinator restraint) — improves coordinator behavior quality
  7. fix(coordinator): persist agent results immediately after read_agent bradygaster/squad#684 (persist agent results) — fixes silent data loss
  8. feat(coordinator): add compaction recovery via session-state.md bradygaster/squad#682 (compaction recovery) — addresses long-session context loss
  9. feat(cli): remove REPL, add deprecation message (#665) bradygaster/squad#675 (remove REPL) — largest change, needs careful rebase, but highest long-term value

🟡 Review Only — Work Done, Needs Review

PR Title Notes
#676 feat: enhance FIDO with PR requirements enforcement + workflow guide 4 docs/governance files, 611 additions. Useful infrastructure but no code. Review for alignment with current team conventions before adopting.
#716 Draft: fix bradygaster#714 packaged SDK export validation Fixes real FSStorageProvider export mismatch in packaged tarballs. Author left as draft — needs confirmation it's ready for review.

🔴 Skipped

PR Title Reason
#679 fix(test): shared Docker skip guard + template-sync timeout Superseded by bradygaster#723 which rebases and adds additional guards.
#680 feat(sdk): StateBackend POC - orphan branch persistence Explicitly DO NOT MERGE — research/POC branch.

Notes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions