fix(docs): address Flight review findings for PRs #647-649#74
Closed
fix(docs): address Flight review findings for PRs #647-649#74
Conversation
Add .gh-resolved to default gh CLI to diberry/squad (not upstream). Add squad-pr-target-guard.yml workflow to validate PR base repo in CI. Prevents accidental PRs to bradygaster/squad from this fork. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace phantom @squad/resilience import with pseudocode example - Fix squad.json -> squad.config.ts convention - Add successThreshold explanation - Scribe charter files already deduplicated on dev branch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
changed the title
Owner
Author
|
Closing: mixed concerns (doc fixes + broken CI guard). Doc fixes will be re-opened as a clean cross-fork PR on bradygaster/squad. CI guard needs a fundamentally different approach (gh repo set-default + branch protection). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge review by Flight found issues in PRs bradygaster#647, bradygaster#648, bradygaster#649 that were merged without team review.
Fixes
PR bradygaster#647 circuit breaker guide:
PRs bradygaster#648/bradygaster#649 charter duplication:
Impact