Skip to content

Feature/fancy pointers#1

Merged
LukasKerk merged 14 commits into
developmentfrom
feature/fancy_pointers
May 20, 2021
Merged

Feature/fancy pointers#1
LukasKerk merged 14 commits into
developmentfrom
feature/fancy_pointers

Conversation

@LukasKerk
Copy link
Copy Markdown

This generalizes the data structure a bit more to be able to handle Allocators that use fancy pointers.

@LukasKerk LukasKerk requested a review from bigerl May 6, 2021 12:52
Copy link
Copy Markdown
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine otherwise

Comment thread tests/CMakeLists.txt

# Boost::unit_test_framework
find_package(Boost 1.54.0 REQUIRED COMPONENTS unit_test_framework)
target_link_libraries(tsl_sparse_map_tests PRIVATE Boost::unit_test_framework)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary whitespace change

Comment thread tests/CMakeLists.txt
# tsl::sparse_map
add_subdirectory(../ ${CMAKE_CURRENT_BINARY_DIR}/tsl)
target_link_libraries(tsl_sparse_map_tests PRIVATE tsl::sparse_map)
target_link_libraries(tsl_sparse_map_tests PRIVATE tsl::sparse_map) No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary whitespace change

Comment thread include/tsl/sparse_hash.h Outdated
Comment thread tests/fancy_pointer/sparse_hash_set_tests.cpp Outdated
Comment thread tests/fancy_pointer/sparse_hash_set_tests.cpp Outdated
Comment thread include/tsl/sparse_hash.h Outdated
@LukasKerk LukasKerk changed the base branch from master to development May 20, 2021 11:23
@LukasKerk LukasKerk marked this pull request as ready for review May 20, 2021 11:26
@LukasKerk LukasKerk merged commit cff9cdb into development May 20, 2021
@LukasKerk LukasKerk deleted the feature/fancy_pointers branch May 20, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants