Skip to content

Conversation

@abdulhp
Copy link
Contributor

@abdulhp abdulhp commented Sep 21, 2023

🐈‍⬛ Backgrounds

Why this task should be worked on?
To bring chunkById database query builder method, so we can improve chunking in Laravel 4

✅ Todo

  • First pairing with Mas Rizqy: Flow of Backporting
  • Explore chunk and cursor related methods from Laravel 10
  • Understand logic of the method and gather all test cases related to the methods
  • Setup Dicoding L42x
    • Creating new branch
    • Backport test cases
    • Backport the codes
  • Create pull request
  • Testing

🚏 Acceptances scenarios

  • testChunkByIdOnArrays
  • testChunkPaginatesUsingIdWithLastChunkComplete
  • testChunkPaginatesUsingIdWithLastChunkPartial
  • testChunkPaginatesUsingIdWithCountZero
  • testChunkPaginatesUsingIdWithAlias

@abdulhp abdulhp requested a review from rizqyhi September 21, 2023 07:08
@abdulhp abdulhp self-assigned this Sep 21, 2023
Copy link
Member

@rizqyhi rizqyhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lgtm.

@rizqyhi rizqyhi merged commit 8db410b into master Sep 22, 2023
@rizqyhi rizqyhi deleted the backport/chunk-by-id branch September 22, 2023 08:51
@rizqyhi rizqyhi restored the backport/chunk-by-id branch September 22, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants