Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think ruby-dicom is a useful gem. I thought it would be good if it was compatible with Ruby3. However, although there is test code, there is no CI. I added CI using GitHub Actions to make it easier to check the impact of changes.
GitHub Actions can be used for free in the Public Repository. https://docs.github.com/ja/billing/managing-billing-for-your-products/about-billing-for-github-actions
I used setup-ruby to set up the Ruby environment in GitHub Actions. I tried to set up the environment with Ruby1.9.3 according to REQUIREMENTS, but gave up and decided to use Ruby2.2 as described in gemspec.
Here are the test results.
I don't have the results to show how many specs were failing before this work. Please let me know if there are any changes that need to be made.