Skip to content

Use key over text in Control Extension#2364

Merged
DymoneLewis merged 1 commit into
didi:masterfrom
MrFastDie:translation-issues
Jan 23, 2026
Merged

Use key over text in Control Extension#2364
DymoneLewis merged 1 commit into
didi:masterfrom
MrFastDie:translation-issues

Conversation

@MrFastDie
Copy link
Copy Markdown
Contributor

Hey guys,

I'd like to use this repo but some things that I like to use are hardcoded right now. To allow translations to different languages I would suggest going from item.text to item.key in this particular place.

I did not look too deep in this, and I am not sure if it has other side effects.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 21, 2026

⚠️ No Changeset found

Latest commit: e6f7c9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DymoneLewis
Copy link
Copy Markdown
Collaborator

Thank you for your contribution! Let me check it.

@DymoneLewis
Copy link
Copy Markdown
Collaborator

Looks fine. I'll release a new version shortly with the changes included, and sync your version number then.(๑•̀ㅂ•́)و✧

@DymoneLewis DymoneLewis merged commit e8fa276 into didi:master Jan 23, 2026
@DymoneLewis
Copy link
Copy Markdown
Collaborator

Morning👋
this PR has been released in release version @logicflow/extension@2.1.12 and pre version @logicflow/extension@2.2.0-alpha.6. You can upgrade to the corresponding version according to your needs.

@MrFastDie
Copy link
Copy Markdown
Contributor Author

Great, thank you a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants