Merged
Conversation
viktormalik
reviewed
Mar 12, 2021
Collaborator
viktormalik
left a comment
viktormalik
left a comment
There was a problem hiding this comment.
LGTM, just small nits
FrNecas
force-pushed
the
frnecas-cbmc-5.7
branch
2 times, most recently
from
b2e050d to
a9abc16
Compare
viktormalik
approved these changes
Mar 12, 2021
Contributor
Author
|
Proposal for how this should be merged: firstly merge the PR in CBMC, modify acbeed7 so that it points to a correct commit, squash this whole PR into 2 commits - one commit for the changes themselves and one for 2LS version update. Do you agree @peterschrammel or can you think of a better way to handle this? |
peterschrammel
approved these changes
Mar 12, 2021
Member
peterschrammel
left a comment
peterschrammel
left a comment
There was a problem hiding this comment.
peterschrammel/cbmc#21 is merged. Please rebase.
Member
Yes, please. |
FrNecas
force-pushed
the
frnecas-cbmc-5.7
branch
from
a9abc16 to
77eaa8f
Compare
Replace i2string with std::to_string. Adjust abstract domains: - In CBMC 5.7, abstract domains work slightly differently than they used to. Methods for creating top, bottom and entry must be implemented. Moreover, the first merge could have no effect resulting in the function not being entered due to changes in abstract interpretation implementation in CBMC. Replace dstring with dstringt. Replace deprecated gen_zero. Fix GOTO check options. Change graph to grapht. Add missing argument to goto_inlinet constructor call. Recompute locations after inlining. Adjust memsafety tests to new checks. Signed-off-by: František Nečas <frantisek.necas@protonmail.com>
Signed-off-by: František Nečas <frantisek.necas@protonmail.com>
FrNecas
force-pushed
the
frnecas-cbmc-5.7
branch
from
77eaa8f to
fbbd676
Compare
Contributor
Author
|
Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on peterschrammel/cbmc#21 , adjusting 2LS to the changes in CBMC 5.7. I will squash the commits before this PR is merged to have an atomic compilable commit but leaving it as is (per type of change) to make reviewing easier. May also require changing the CBMC commit used once peterschrammel/cbmc#21 is merged.
Major changes
make_bottom,make_topandmake_entrymethods. The changes also required adjustingmergereturn value in our domains to make the analyses work correctly. The fix was inspired by Data-flow analysis must always enter new function cbmc#327