Fix constant propagator merge operator#1057
Closed
peterschrammel wants to merge 3 commits intodiffblue:masterfrom
Closed
Fix constant propagator merge operator#1057peterschrammel wants to merge 3 commits intodiffblue:masterfrom
peterschrammel wants to merge 3 commits intodiffblue:masterfrom
Conversation
Previously there were two loops which have been consolidated, which caused the value not being set to top when two constants clash. Also, a spurious break statement caused an incomplete merge leading to erroneous substitutions.
tautschnig
reviewed
Jun 25, 2017
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Thus far looks good to me; but may I suggest to place "Regression test for constant propagator merge bug" with or after the commit fixing it? That would enable "git bisect" without spurious failures.
Member
Author
|
Closing for now. I'll revisit these fixes once #966 (which heavily modifies the constant propagator) has been merged. |
Collaborator
|
Could the regression test provided in this PR be added to #966 asap, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit cleans up the linting issues. Recommended to review the commits separately.
Do not merge: more fixes to come.