Linking: replace conflicting pointer types when one declaration is extern by tautschnig · Pull Request #2024 · diffblue/cbmc

tautschnig · 2018-04-09T18:20:17Z

No description provided.

smowton

lgtm

martin-cs

The parts of it that touch my world look good.

kroening · 2018-06-01T09:56:00Z

src/ansi-c/c_typecheck_base.cpp

+      warning().source_location = symbol.value.find_source_location();
+      warning() << "`extern' symbol should not have an initializer" << eom;
+    }
  }


Turn into error when in gcc or clang mode?

kroening · 2018-06-01T09:57:27Z

src/util/replace_symbol.cpp

-  const bool replace_with_const) const
+  const bool replace_with_const,
+  const bool ignore_type_change) const
 {


I think this is getting to bizarre, and to linker specific. I'd make that a separate piece of code, just for the linker.

Work in progress, #2720 and #2721 are the first PRs to enable this. More to come.

tautschnig · 2018-08-13T13:21:12Z

This is now implemented on top of #2723 with the suggested, linker-specific implementation.

allredj

This PR failed Diffblue compatibility checks (cbmc commit: 6e921c2).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

allredj

This PR failed Diffblue compatibility checks (cbmc commit: 6e921c2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/83986092
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

allredj

Passed Diffblue compatibility checks (cbmc commit: c720555).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84011100

allredj

Passed Diffblue compatibility checks (cbmc commit: e8b03a7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84094002

allredj

Passed Diffblue compatibility checks (cbmc commit: d7dae29).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86154692

tautschnig · 2018-10-03T14:59:44Z

@kroening ping?

allredj

Passed Diffblue compatibility checks (cbmc commit: 2f60e13).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86766275

…tern

allredj

Passed Diffblue compatibility checks (cbmc commit: 80ff4e5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86776976

tautschnig requested review from chrisr-diffblue, kroening, martin-cs, peterschrammel and smowton as code owners April 9, 2018 18:20

tautschnig force-pushed the extern-linking branch from 760202c to c8dc07a Compare April 10, 2018 07:46

smowton approved these changes Apr 10, 2018

View reviewed changes

tautschnig force-pushed the extern-linking branch from c8dc07a to 252d815 Compare April 10, 2018 08:12

tautschnig assigned kroening, peterschrammel, martin-cs and chrisr-diffblue Apr 10, 2018

tautschnig force-pushed the extern-linking branch from 252d815 to e1b62b9 Compare April 16, 2018 05:36

martin-cs approved these changes May 17, 2018

View reviewed changes

tautschnig unassigned martin-cs and chrisr-diffblue May 17, 2018

tautschnig force-pushed the extern-linking branch from e1b62b9 to d847b6c Compare May 23, 2018 09:57

kroening reviewed Jun 1, 2018

View reviewed changes

tautschnig assigned tautschnig and unassigned kroening and peterschrammel Jun 1, 2018

tautschnig force-pushed the extern-linking branch from d847b6c to 5c8171f Compare August 11, 2018 11:33

tautschnig requested a review from pkesseli as a code owner August 11, 2018 11:33

tautschnig force-pushed the extern-linking branch from 5c8171f to 3086f21 Compare August 13, 2018 13:19

tautschnig requested a review from thk123 as a code owner August 13, 2018 13:19

tautschnig force-pushed the extern-linking branch 3 times, most recently from 6b111a4 to 6a20f61 Compare August 18, 2018 13:30

tautschnig force-pushed the extern-linking branch from 6a20f61 to cbd5d9f Compare August 31, 2018 13:46

tautschnig assigned kroening and peterschrammel and unassigned tautschnig Aug 31, 2018

tautschnig force-pushed the extern-linking branch from cbd5d9f to 6e921c2 Compare September 6, 2018 10:21

allredj reviewed Sep 6, 2018

View reviewed changes

tautschnig force-pushed the extern-linking branch from 6e921c2 to c720555 Compare September 6, 2018 13:30

allredj reviewed Sep 6, 2018

View reviewed changes

tautschnig force-pushed the extern-linking branch from c720555 to e8b03a7 Compare September 7, 2018 06:50

allredj reviewed Sep 7, 2018

View reviewed changes

peterschrammel approved these changes Sep 24, 2018

View reviewed changes

peterschrammel removed their assignment Sep 24, 2018

tautschnig force-pushed the extern-linking branch from e8b03a7 to d7dae29 Compare September 27, 2018 12:43

allredj reviewed Sep 27, 2018

View reviewed changes

tautschnig force-pushed the extern-linking branch from d7dae29 to 2f60e13 Compare October 3, 2018 15:15

allredj reviewed Oct 3, 2018

View reviewed changes

Linking: replace conflicting pointer types when one declaration is ex…

80ff4e5

…tern

tautschnig force-pushed the extern-linking branch from 2f60e13 to 80ff4e5 Compare October 3, 2018 17:19

allredj reviewed Oct 3, 2018

View reviewed changes

kroening approved these changes Oct 3, 2018

View reviewed changes

tautschnig merged commit a1e86d3 into diffblue:develop Oct 3, 2018

tautschnig deleted the extern-linking branch October 3, 2018 18:23

Conversation

tautschnig commented Apr 9, 2018

Uh oh!

smowton left a comment

Choose a reason for hiding this comment

Uh oh!

martin-cs left a comment

Choose a reason for hiding this comment

Uh oh!

kroening Jun 1, 2018

Choose a reason for hiding this comment

Uh oh!

kroening Jun 1, 2018

Choose a reason for hiding this comment

Uh oh!

tautschnig Aug 11, 2018

Choose a reason for hiding this comment

Uh oh!

tautschnig commented Aug 13, 2018

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

tautschnig commented Oct 3, 2018

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants