Allow accessing pointer type selector via friend function#2301
Closed
mgudemann wants to merge 1 commit intodiffblue:developfrom
Closed
Allow accessing pointer type selector via friend function#2301mgudemann wants to merge 1 commit intodiffblue:developfrom
mgudemann wants to merge 1 commit intodiffblue:developfrom
Conversation
mgudemann
requested review from
cesaro,
peterschrammel,
smowton and
thk123
as code owners
majakusber
reviewed
Jun 7, 2018
|
|
||
| // friend function to access pointer type selector in unit tests | ||
| friend const select_pointer_typet & | ||
| get_pointer_type_selector_unit(const java_bytecode_languaget &); |
There was a problem hiding this comment.
Is the function definition part of some other PR?
Contributor
Author
There was a problem hiding this comment.
yes, it had planned to make it live in TG, but I could also add it to jbmc unit java-testing-utils
There was a problem hiding this comment.
If it would only be in TG but not in jbmc (which is open source), I'm thinking people might be tempted to delete it maybe because they won't see the reason for it. What do you think?
tautschnig
previously requested changes
Jun 7, 2018
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
No far-away friend declarations, please. Let alone any that aren't even in the same repository. If that to-be friend needs access to members, make all those members public instead.
mgudemann
force-pushed
the
enhancement/friend_select_pointer_type
branch
from
3f90202 to
3b321b7
Compare
majakusber
approved these changes
Jun 7, 2018
Contributor
Author
|
@svorenova @tautschnig I think this is completely resolvable in TG |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for unit testing in TG