Skip to content

boolbvt error handling for byte_extract#2501

Closed
kroening wants to merge 1 commit intodevelopfrom
boolbvt_error_handling
Closed

boolbvt error handling for byte_extract#2501
kroening wants to merge 1 commit intodevelopfrom
boolbvt_error_handling

Conversation

@kroening
Copy link
Copy Markdown
Collaborator

@kroening kroening commented Jul 1, 2018

boolbvt does not throw exceptions in case unsupported expressions are given; instead, it calls conversion_failed, which calls ignoring().

Copy link
Copy Markdown
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 8301743).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77795181

@tautschnig tautschnig self-assigned this Jul 2, 2018
@tautschnig
Copy link
Copy Markdown
Collaborator

I'll take a look and provide comments on this: it should be co-ordinated with existing open issues on cleaning up exceptions and also the refactoring of flatten_byte_extract.

kroening added a commit that referenced this pull request Nov 7, 2018
Move flatten_byte_* to lowering [blocks: #2068, #2501]
@tautschnig tautschnig removed their assignment Nov 7, 2018
@tautschnig
Copy link
Copy Markdown
Collaborator

In light of #3290 merged, this needs to be reconsidered and at bare minimum rebased.

Copy link
Copy Markdown
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but I agree with @tautschnig 's comments about whether this is the thing to do.

@kroening kroening force-pushed the boolbvt_error_handling branch from 8301743 to 56194ef Compare November 8, 2018 13:39
Copy link
Copy Markdown
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
Diffblue compatibility check is currently unavailable.
Please create manual bump.
(cbmc commit: 56194ef).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90716260

Copy link
Copy Markdown
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've merged the various byte extract/byte update fixes: this seems like the right thing to do, except it's actually needed in more places: tautschnig@deaa887 might provide guidance.

@tautschnig
Copy link
Copy Markdown
Collaborator

I'm of course biased, but I'd by now actually prefer #4651 (plus a follow-up PR that replaces the two remaining two throws by invariants).

@tautschnig
Copy link
Copy Markdown
Collaborator

I've not put up #4691, which ought to make this one unnecessary.

@tautschnig
Copy link
Copy Markdown
Collaborator

Closing as this is no longer applicable with #4691 merged.

@tautschnig tautschnig closed this May 30, 2019
@tautschnig tautschnig deleted the boolbvt_error_handling branch May 30, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants