Convert asserts and throws to INVARIANTs for files starting with g#2836
Closed
apaschos wants to merge 1 commit intodiffblue:developfrom
apaschos:cleanup_error_handlingG
Closed
Convert asserts and throws to INVARIANTs for files starting with g#2836apaschos wants to merge 1 commit intodiffblue:developfrom apaschos:cleanup_error_handlingG
apaschos wants to merge 1 commit intodiffblue:developfrom
apaschos:cleanup_error_handlingG
Conversation
apaschos
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
Collaborator
|
passing the source_locationt into the error message as a string is a big downgrade; the current implementation is able to format these in JSON/XML etc. It is unclear to me why this is better than before. |
kroening
requested changes
Aug 25, 2018
Collaborator
kroening
left a comment
kroening
left a comment
There was a problem hiding this comment.
Don't get why we do this.
Contributor
|
I have taken over the development of this PR. Development will continue in #2904. Closing this as I can not push against it, seeing as the target repository has been deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing INVARIANTs for the remaining files that start with g. No tests added yet. I do expect a lot of changes to happen.