Closed
Conversation
tautschnig
approved these changes
Sep 19, 2018
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
Looks ok to me modulo CI passing.
peterschrammel
approved these changes
Sep 19, 2018
48a2996 to
3d9c1ff
Compare
3d9c1ff to
570333b
Compare
570333b to
475b766
Compare
tautschnig
requested changes
Feb 5, 2019
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
A lot of tests are disabled without providing a justification or a path forward.
Contributor
|
Closing due to age (no further comment on PR content), please reopen with rebase on develop if you intent to continue this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.