Avoid shadowing of variables (several instances) [blocks: #2310]#3415
Avoid shadowing of variables (several instances) [blocks: #2310]#3415kroening merged 14 commits intodiffblue:developfrom
Conversation
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs and
peterschrammel
as code owners
chrisr-diffblue
left a comment
chrisr-diffblue
left a comment
There was a problem hiding this comment.
Many thanks for all the cleanup - looks like a great improvement.
It's completely outside the scope of this PR of course, but it does make me wonder if we should have a play with something like clang-tidy to see if we could have a lint-like job to check for this kind of shadowing.
It's another iterator already in use, just rename this instance to "entry."
Renamed the first declaration, which really we don't use as an iterator.
It is a class member, no need to pass it around as a parameter shadowing the very same reference.
Just use a ranged for instead.
Renamed parameter to "subsumed_path".
Having just one of these as "num_symbols" is sufficient.
Both cleanup (using ranged for) and fix of shadowing.
It is never used and shadows a class member.
Rename the first declaration to "source_line"
Rename the first declaration to "lock_entry".
Use target_index instead to avoid shadowing.
We pass different sets of cycles in there, only sometimes the actual class member itself.
This avoids shadowing.
Just remove the parameter.
tautschnig
force-pushed
the
vs-shadow-1
branch
from
4e47e2c to
ee34d34
Compare
Once #2310 is in place you won't get past CI anymore if you introduce shadowing. It's just that #2310 has quite a lot of commit left for me to put into reviewable PRs, which I'll do once I've got the current batch approved and merged. |
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: ee34d34).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91452422
7 participants
Please review commit-by-commit.